refactor: goods refactoring #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: use `$.log.output` as default spinner output build: remove goods bundle
e2b6953 to
3540930
Compare
There was a problem hiding this comment.
Copilot reviewed 15 out of 18 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- .nycrc: Language not supported
- .size-limit.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/goods.ts:227
- The refactored expBackoff implementation now computes the delay as 'randMs * 2 ** n' without any random jitter, whereas the previous version added a random component. Please confirm that removing the randomness is intentional, as this changes the backoff behavior.
const randMs = parseDuration(delay)
| @@ -224,10 +224,12 @@ export function getCallerLocationFromString(stackString = 'unknown'): string { | |||
| const lines = stackString | |||
| .split(/^\s*(at\s)?/m) | |||
| .filter((s) => s?.includes(':')) | |||
| const i = lines.findIndex((l) => l.includes('Proxy.set')) | |||
| const offset = i < 0 ? i : i + 2 | |||
There was a problem hiding this comment.
Using a negative index for 'offset' when 'Proxy.set' is not found may lead to undefined behavior in the caller location lookup. Consider setting a default positive offset instead of passing a negative one.
Suggested change
| const offset = i < 0 ? i : i + 2 | |
| const offset = i < 0 ? 0 : i + 2 |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
expBackoffimplementationgoodschunkquestion()I/O$.log.outputas default spinner output