Detect and report ASLR status #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theoretically, we could just disable ASLR in `main()`, but that seems to be disallowed by default by some other security features. Refs. google#461
dmah42
reviewed
May 1, 2025
docs/reducing_variance.md
Outdated
| you might want to disable the ASLR security hardening feature while running the | ||
| benchmark. | ||
|
|
||
| To globally disable ASLR, run |
There was a problem hiding this comment.
these instructions only apply to linux i think? windows also has ASLR available.
There was a problem hiding this comment.
I have no clue about non-linux, sorry.
There was a problem hiding this comment.
(i assume you don't care given the change in the code, but it might be worth mentioning in the documentation)
There was a problem hiding this comment.
Makes sense. Is this verbiage sufficient?
dmah42
previously approved these changes
May 1, 2025
dmah42
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theoretically, we could just disable ASLR in
main(), but that seems to be disallowed by defaultby some other security features.
Refs. #461