Add an option to use system protobuf. #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cuts down the compilation time significantly, and almost cuts the binary size in half. However, for this to work, libbloaty must be a shared object rather than a static one. I implemented just that and added it to the installation.
|
It now no longer creates a shared library by default, since apparantly Apple doesn't like mixing shared and static libraries. |
|
Thanks for the pull request and sorry for the delay. I ended up merging #155 which is a similar idea but larger scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #142, it would be nice to have an option to use system libraries rather than compiling everything for this package alone. This patch implements just that.
For this to work properly,
liblibbloatycan no longer be a static object since it may have to depend on the shared libprotobuf instance. I hope this is not too big of an issue.On my laptop, compilation times are pretty much halved, as is the binary size.