8000 Rename the `blocklyTreeRow` CSS class to `blocklyToolboxCategory` · Issue #8345 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename the blocklyTreeRow CSS class to blocklyToolboxCat 8000 egory #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BeksOmega opened this issue Jul 12, 2024 · 3 comments
Closed

Rename the blocklyTreeRow CSS class to blocklyToolboxCategory #8345

BeksOmega opened this issue Jul 12, 2024 · 3 comments
Assignees
@Abhinav-Chdhary
Labels
good first issue help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

Rename any references to blocklyTreeRow to blocklyToolboxCategory.

This change should be made against the rc/v12.0.0 branch. This should be marked as a breaking change.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 12, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 12, 2024
@Abhinav-Chdhary
Copy link
Contributor

Hi Beka! Can I work on this?

I tried to identify the files that reference to blocklyTreeRow and there are only 3.
Is there anything else I should change except just renaming?

@BeksOmega
Copy link
Collaborator Author

Go for it @Abhinav-Chdhary =) Nope just those changes!

Abhinav-Chdhary added a commit to Abhinav-Chdhary/blockly that referenced this issue Jul 14, 2024
@Abhinav-Chdhary
fix: google#8345 rename css class
b835262 
This commit renames the blocklyTreeRow CSS class to blocklyToolboxCategory
Abhinav-Chdhary added a commit to Abhinav-Chdhary/blockly that referenced this issue Jul 14, 2024
@Abhinav-Chdhary
fix!: google#8345 rename css class
2cf76f1 
This commit renames the blocklyTreeRow CSS class to blocklyToolboxCategory
@Abhinav-Chdhary Abhinav-Chdhary mentioned this issue Jul 14, 2024
Merged
1 task
BeksOmega pushed a commit that referenced this issue Jul 16, 2024
@Abhinav-Chdhary
fix!: Rename blocklyTreeRow and blocklyToolboxCategory CSS classes (
ae2fea4 
#8357)

* fix!: #8345 rename css class

This commit renames the blocklyTreeRow CSS class to blocklyToolboxCategory

* Update category.ts

* fix: css class conflicts

Rename original blocklyToolboxCategory to blocklyToolboxCategoryContainer
@BeksOmega
Copy link
Collaborator Author

Closed by #8357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abhinav-Chdhary Abhinav-Chdhary

Labels
good first issue help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
v12
Development

No branches or pull requests
2 participants
@BeksOmega @Abhinav-Chdhary
0