fix: drag strategy only clear group id set by us #8355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cpcallen
requested changes
Jul 17, 2024
|
Hi @cpcallen! Thanks for reviewing, I just updated the code according to your change request! |
cpcallen
approved these changes
Jul 19, 2024
|
@HollowMan6: test failures are due to issues with node.js v22.5.0 (see #8392 and #8393). Can you rebase this PR onto latest |
We should add a condition check so that we don't unset the group ID that is not set by us, otherwise, the multi-select plugin undo/redo will be broken (apply individually instead of all together) Signed-off-by: Hollow Man <hollowman@opensuse.org>
Done! |
|
Hi @HollowMan6 and @ewpatton This change has caused some issues with ending event groups when you drag a block out of the toolbox (#8764). I'm not very familiar with the multi-select plugin, so I'm not sure what options there are for an alternative fix. Would you like to take a look before I revert this change and file an issue to follow up on the plugin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes mit-cml/workspace-multiselect#62 (comment)
Proposed Changes
We should add a condition check so that we don't unset the group ID that is not set by us, otherwise, the multi-select plugin undo/redo will be broken (apply individually instead of all together)
Reason for Changes
If not, then a monkey patch will be needed on the multi-selection plugin side.
Test Coverage
Documentation
Additional Information