8000 fix!: renamed blocklyTreeIcon Css class to blocklyToolboxCategoryIcon #8347 by krishchvn · Pull Request #8367 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix!: renamed blocklyTreeIcon Css class to blocklyToolboxCategoryIcon #8347 #8367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

krishchvn
Copy link
Contributor

The basics

Fixes #8347

Proposed Changes

This pull request is for renaming blocklyTreeIcon with blocklyToolboxCategoryIcon.
This is marked as a breaking change.
Pull request is created against rc/v12.0.0 branch.

@krishchvn krishchvn requested a review from a team as a code owner July 15, 2024 21:12
Copy link
google-cla bot commented Jul 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
conventional-commit-lint-gcf bot commented Jul 15, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Jul 15, 2024
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for rachel-fenichel July 15, 2024 21:19
Copy link
Collaborator
@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the fixes.

Once this passes CI I'll get this merged =) However, I think it might fail because of some incorrect whitespace. If the formatting check fails, you can run npm run format in the root directory to fix it.

@krishchvn
Copy link
Contributor Author
8000

Hi @BeksOmega, I've fixed the formatting. Thanks :)

@BeksOmega
Copy link
Collaborator

Thanks again @krishchvn :D

@BeksOmega BeksOmega merged commit 33b5371 into google:rc/v12.0.0 Jul 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0