8000 feat: Add blocklyField to field's SVG Group by nullHawk · Pull Request #8334 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add blocklyField to field's SVG Group #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

nullHawk
Copy link
Contributor

The basics

The details

Added .blocklyField to fieldGroup_ using dom.addClass()

Resolves

#8289

@nullHawk nullHawk requested a review from a team as a code owner July 12, 2024 07:48
@nullHawk nullHawk requested a review from cpcallen July 12, 2024 07:48
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@nullHawk nullHawk changed the title Add blocklyField to field's SVG Group feat: Add blocklyField to field's SVG Group Jul 12, 2024
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 12, 2024
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 12, 2024 15:58
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Jul 12, 2024
Copy link
Collaborator
@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fix =) Once CI passes I'll get this merged.

@BeksOmega BeksOmega merged commit 5a32c3f into google:rc/v12.0.0 Jul 12, 2024
9 checks passed
@nullHawk
Copy link
Contributor Author

This looks great! Thank you for the fix =) Once CI passes I'll get this merged.

Happy to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0