fix: use copyable interface for cut action, add tests #8993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHenning
approved these changes
May 6, 2025
| * Creates a block and sets its nextConnection as the focused node. | ||
| * @param {Blockly.Workspace} workspace The workspace to create a new block on. | ||
| */ | ||
| function setSelectedConnection(workspace) { |
There was a problem hiding this comment.
It may be ideal to set up a situation with a real focusable node rather than spying, if possible (just for better integration verification with the rest of Blockly and to reduce the risk of functional disparity over time).
There was a problem hiding this comment.
Filed #8996 as a follow up
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Works on google/blockly-keyboard-experimentation#488
Proposed Changes
keydown_testtoshortcut_items_test(in a separate commit in case github makes the diff confusing)ICopyableinterface instead ofISelectablefor the cut preconditionReason for Changes
Adding tests and making the behavior consistent
I renamed the file because this is the second time I've thought there were no tests for the existing keyboard shortcuts, only to find there are, just under a file name that doesn't match where the behavior is defined.
Test Coverage
yes
Documentation
Additional Information