fix!: delete IASTNodeLocation and friends #9015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9006
Proposed Changes
Delete
IASTNodeLocation,IASTNodeLocationWithBlock, andIASTNodeLocationSvg.Reason for Changes
These interfaces were used by ASTNode and Cursor code to define what properties could be found on various node locations. #8992 moved us to use
INavigableinstead ofASTNode, and usesinstanceofinstead of interfaces to check properties.Test Coverage
Ran tests in core.
Documentation
Breaking change: Removes three interfaces:
IASTNodeLocation,IASTNodeLocationWithBlock, andIASTNodeLocationSvg. They were used by keyboard navigation code and not expected to be used by code outside of Blockly-authored plugins.Additional Information
More cleanup!