fix!: remove deprecated setEnabled and backwards event filtering #9039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9038
Proposed Changes
setEnabledfunctions fromBlockandBlockSvg.forwardparameter fromBlockly.Events.filterand updates usages.BREAKING CHANGES
If you call
block.setEnabled, update to callblock.setDisabledReasoninstead. A block could be disabled for multiple reasons, and callingsetDisabledReasonmultiple times for each of these reasons is supported and encouraged. A block will only appear enabled if there are no disabled reasons remaining. Blockly will now manage this state for you.Calling
Blockly.Events.filter()with theforwardparameter set to false is no longer supported. If you only call this function with the second parameter set totrueyou can simply remove the parameter. If you are ever calling this function with the second parameter set tofalse, you are doing something complex and error-prone. Please get in touch on the forum, or see this PR and the linked issues for context.