8000 Add type guards for NodeOrText by tushuhei · Pull Request #830 · google/budoux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add type guards for NodeOrText #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2024
Merged

Add type guards for NodeOrText #830

merged 4 commits into from
Nov 28, 2024

Conversation

tushuhei
Copy link
Member

Use user-defined type guards to handle Node vs string in a more IDE-friendly way.

@tushuhei tushuhei requested a review from kojiishi November 28, 2024 02:05
@tushuhei tushuhei requested a review from kojiishi November 28, 2024 13:02
kojiishi
kojiishi approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator
@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tushuhei tushuhei merged commit 2e89bb6 into main Nov 28, 2024
26 checks passed
@tushuhei tushuhei deleted the typeguard-nodeortext branch December 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @kojiishi
0