Replace JSDOM with linkedom #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #888. This change replaces JSDOM with linkedom to support SSR.
JSDOM has been used for HTML processing in Node.js environments, but it doesn't work well with SSR (e.g., Vite) because the library is written in CommonJS. Linkedom seems like a good alternative to JSDOM, with a lighter implementation and a design that keeps SSR in mind.
Although the behavior is not 100% identical to JSDOM (see test cases for
white-space: nowrap), I believe this satisfies most use cases required for Node.js environments. If users need elaborate HTML processing considering style cascades etc., they can let the client-side code to do the process.