8000 Rename applyElement to applyToElement by tushuhei · Pull Request #348 · google/budoux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename applyElement to applyToElement #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

tushuhei
Copy link
Member

Rename applyElement to applyToElement to make it align with HTMLProcessor's API and avoid confusion. (It will apply the change to the element, but not apply the element to something else.)

@tushuhei tushuhei requested a review from kojiishi October 30, 2023 02:12
Copy link
Collaborator
@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kojiishi kojiishi merged commit dbb8837 into main Oct 30, 2023
@tushuhei tushuhei deleted the deprecate-applyelement branch December 12, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0