Functions for upper / lower casing ASCII characters in strings. #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @bitsofinfo regarding tektoncd/triggers#638 |
JimLarson
approved these changes
Jul 8, 2020
ext/README.md
Outdated
| @@ -64,6 +63,20 @@ Examples: | |||
| 'hello mellow'.lastIndexOf('ello', 6) // returns 1 | |||
| 'hello mellow'.lastIndexOf('ello', -1) // error | |||
|
|
|||
| ### LowerAscii | |||
|
|
|||
| Produces a new string where all ASCII characters are lower-cased. | |||
There was a problem hiding this comment.
"Returns" instead of "produces", for consistency. (Okay, I see "produces" elsewhere, but let's start converging on "returns".) Here and elsewhere.
ext/strings.go
Outdated
| func lowerASCII(str string) string { | ||
| runes := []rune(str) | ||
| for i, r := range runes { | ||
| if r&unicode.MaxASCII == r { |
There was a problem hiding this comment.
if r <= unicode.MaxASCII seems to be more idiomatic, but I'm okay with it as-is. Here and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces extension functions for upper / lower casing ASCII characters in strings.
Closes #370