Add RunWith annotations #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers' codebases and run in non-maven hosted test runners.
cgruber
added a commit
that referenced
this pull request
Feb 21, 2013
Add RunWith annotations (Approved internally)
Merged
nick-someone
pushed a commit
that referenced
this pull request
Jul 30, 2020
Note: This CL forks some auto-common for two reasons:
1. SuperficialValidation: We need access to SuperficialValidation#validateType(), which is not publicly accessible. Rather than just copy over those specific methods, I've just forked the entire class so that it's clearer what the difference is. I've also sent out [] to open up visibility, but this could take a while since we also have to wait for a new push of the auto-common artifact, then update that artifact in bazel-common, then update Dagger's version of bazel-common.
2. BasicAnnotationProcessor: There is a bug in the last publicly released version of BasicAnnotationProcessor ("com.google.auto:auto-common:0.10") which can send deferred elements to the wrong processing step. This is fixed in internally, but auto-common was last released on Jan. 2018, so those fixes haven't made it into the public artifacts.
Once we both of issue #1 is fixed, and we've pushed a new public release of auto-common we can remove both of these forks.
RELNOTES=Fix issue with @BINDS when impl extends generated type.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=323833905
nick-someone
pushed a commit
that referenced
this pull request
Jul 30, 2020
Note: This CL forks some auto-common for two reasons:
1. SuperficialValidation: We need access to SuperficialValidation#validateType(), which is not publicly accessible. Rather than just copy over those specific methods, I've just forked the entire class so that it's clearer what the difference is. I've also sent out [] to open up visibility, but this could take a while since we also have to wait for a new push of the auto-common artifact, then update that artifact in bazel-common, then update Dagger's version of bazel-common.
2. BasicAnnotationProcessor: There is a bug in the last publicly released version of BasicAnnotationProcessor ("com.google.auto:auto-common:0.10") which can send deferred elements to the wrong processing step. This is fixed in internally, but auto-common was last released on Jan. 2018, so those fixes haven't made it into the public artifacts.
Once we both of issue #1 is fixed, and we've pushed a new public release of auto-common we can remove both of these forks.
RELNOTES=Fix issue with @BINDS when impl extends generated type.
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=323833905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RunWith annotations so Dagger can build from source inside customers' codebases and run in non-maven hosted test runners.