Migrate to using AGP's new variant API in the 'variant' package. #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8318a5a to
4fe62ba
Compare
This change adds compatibility classes to support registering an ASM transform in AGP 4.2, 7.0 and 7.1. For 4.2 reflection has to be used for all invocations of the newer variant API since their package in 4.2 is different and its not possible to reference the classes when compiling against a newer version. For 7.0 an onwards, the API are stable and can be referenced directly. Fixes #2700 RELNOTES=Fix an incompatibility in the Hilt Gradle Plugin with AGP 7.0-beta04 and 7.1-alpha03, be aware that with this fix the HiltGradlePlugin will not work with other older alpha/beta versions of AGP 7.0 and 7.1 other than the ones mentioned in these notes. PiperOrigin-RevId: 383895392
4fe62ba to
be2f89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to using AGP's new variant API in the 'variant' package.
This change adds compatibility classes to support registering an ASM transform in AGP 4.2, 7.0 and 7.1. For 4.2 reflection has to be used for all invocations of the newer variant API since their package in 4.2 is different and its not possible to reference the classes when compiling against a newer version. For 7.0 an onwards, the API are stable and can be referenced directly.
Fixes #2700
RELNOTES=Fix an incompatibility in the Hilt Gradle Plugin with AGP 7.0-beta04 and 7.1-alpha03, be aware that with this fix the HiltGradlePlugin will not work with other older alpha/beta versions of AGP 7.0 and 7.1 other than the ones mentioned in these notes.