Fix left-nav height and padding #1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
413eb0f to
cff5757
Compare
|
@yann-soubeyrand - might you be available to review and or comment on this PR? Thanks. |
Sure, but I’m clearly not a CSS guru: I just fixed two small issues, which took me a lot of time due to my CSS skill! 😆 Anyway, this looks good to me and the visuals are convincing. |
|
Works as expected! |
cff5757 to
6652fd3
Compare
|
Thanks all for your feedback. |
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sidebar_search_disable#1658max-heightand top-padding of thetd-sidebar-navdepending on.Site.Params.ui.sidebar_search_disablemd, the sidebar search is always shown, regardless of the value ofsidebar_search_disable(
lg,mdandsmscreens) x (each case of whethersidebar_search_disableis true or not)sidebar_menu_foldableset to truePossible followup change to be addressed:
Screenshots -
sidebar_search_disable:trueNotes:
lgandmdscreenshots were taken with Firefoxsidebar_search_disable:trueView:
lg- notice the full sidenav height in the "After" image, and the top padding fixThe "Before" image is from the current production server, but with the search-box manually hidden.
View:
md- notice the full sidenav height in the "After" imageView:
sm- no change here (other than a tweak to the bottom paddingScreenshots -
sidebar_search_disable:falseView:
lg- notice the full sidenav height in the "After" imageView:
md- notice the full sidenav height in the "After" imageView:
sm- no change here (other than a tweak to the bottom padding