Switch filament and backend to Abseil logging #8691
Conversation
|
Will you be able to check how this affect the binary size on a release build? |
Yes, I'm planning on check that. Unfortunately I think Abseil log uses std iostream, so we may see a binary size increase. |
| @@ -772,26 +774,25 @@ UTILS_NOINLINE | |||
| } else { | |||
| line = shader.substr(start, end - start); | |||
| } | |||
| out << lc++ << ": " << line.c_str() << '\n'; | |||
| LOG(ERROR) << lc++ << ": " << line.c_str(); | |||
There was a problem hiding this comment.
I wonder if this should be a utils/std::stream, and then output to LOG(ERROR) at the end.
There was a problem hiding this comment.
Yeah, I thought about that. The difference is that with LOG(ERROR), Abseil prepends metadata for each line. I guess we have to decide which style we prefer.
0585a5d to
3359ef4
Compare
|
I'm seeing a 208.84 KiB binary size increase on Android. jni/arm64-v8a/libfilament-jni.so:
|
3359ef4 to
bd1cfba
Compare
| LogLine& operator=(const LogLine&) = delete; | ||
| LogLine& operator=(LogLine&&) = delete; | ||
|
|
||
| ~LogLine() noexcept { mStream << utils::io::endl; } |
There was a problem hiding this comment.
The semantics here is a little different from the old since it'll be flushed when the LogLine goes out of scope, as oppose to when <<utils::io::endl is used in the code.
There was a problem hiding this comment.
Yeah, the semantics are indeed different. I did my best to find all the places we weren't using utils::io::endl and instead use a stringstream first to concatenate. IMO the way we did it explicitly with utils::io::endl is a better API, but this is just how Abseil works. I really wish Abseil had a LOG_NOENDLINE-style macro, but it doesn't.
This switches everything under
filament/to Abseil logging. The following mapping betweenutils::slogand Abseil severity is used: