Switch to block-based stage-pool for Vulkan #8742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poweifeng
reviewed
May 15, 2025
phoenixxxx
reviewed
May 19, 2025
rafadevai
reviewed
May 19, 2025
rafadevai
reviewed
May 20, 2025
rafadevai
reviewed
May 20, 2025
e62cd28 to
7084ee2
Compare
poweifeng
reviewed
May 21, 2025
rafadevai
reviewed
May 22, 2025
rafadevai
reviewed
May 22, 2025
rafadevai
reviewed
May 27, 2025
3ac97a6 to
dcc20fc
Compare
dcc20fc to
4e55931
Compare
rafadevai
approved these changes
Jun 4, 2025
Instead of allocating a staging buffer every time one is needed, allocate a large (8mb) block of memory, and divvy it up as needed. We will make this configurable in the future, to allow for tuning for different apps as needed.
Instead of having the child block be a unique_ptr that we create a separate container for within the command buffers, just have the stage block segments be fvkmemory::Resource instances.
- As per discussion with @poweifeng, change the name of a variable called "stage" to "stageSegment" for clarity - As per discussion with @rafadevai, change the order of terminate calls in VulkanDriver to better reflect cleanup order of some objects.
In order to prevent flushing more atoms than were modified when writing data to host-mapped memory in a staging buffer, ensure that all segments allocated are aligned to nonCoherentAtomSize. Also - fix merge conflict compile errors.
4e55931 to
d8517e0
Compare
poweifeng
approved these changes
Jun 4, 2025
phoenixxxx
approved these changes
Jun 5, 2025
9253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allocating a staging buffer every time one is needed, allocate a large (8mb) block of memory, and divvy it up as needed. We will make this configurable in the future, to allow for tuning for different apps as needed.