vk: implement proper offset when uploading to texture #8830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejado
approved these changes
Jun 6, 2025
| size_t const pixelSize = PixelBufferDescriptor::computeDataSize(p.format, p.type, 1, 1, 1); | ||
| size_t const pbdStride = p.stride ? p.stride : width; | ||
|
|
||
| // Slow path of copying row by row |
There was a problem hiding this comment.
Is the first branch the slow path? Maybe use UTILS_UNLIKELY
We didn't take into account the top/left/stride parameters of the PixelBufferDescriptor.
14d5350 to
9ca3504
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't take into account the top/left/stride parameters of the PixelBufferDescriptor.