10000 webgpu: Fix Android material compilation by kpiascik · Pull Request #8832 · google/filament · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

webgpu: Fix Android material compilation #8832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Conversation

kpiascik
Copy link
Contributor
@kpiascik kpiascik commented Jun 6, 2025

Instead of requiring GL_EXT_shader_non_constant_global_initializers we can just make the new variables const

BUGS=[421457710]

Instead of requiring GL_EXT_shader_non_constant_global_initializers
we can just make the new variables const

BUGS=[421457710]
@kpiascik kpiascik added internal Issue/PR does not affect clients webgpu Issues/features for WebGPU backend labels Jun 6, 2025
@bridgewaterrobbie
Copy link
Contributor

lgtm, but please wait for Powei/Ben to approve too

@kpiascik kpiascik merged commit 418dad8 into main Jun 6, 2025
16 checks passed
@kpiascik kpiascik deleted the piascik/androidMatFix branch June 6, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients webgpu Issues/features for WebGPU backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0