Create simple gltf viewer based on gltf_instances, primarily to facilitate webgpu development #8833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpiascik
reviewed
Jun 6, 2025
2b0d690 to
3b07058
Compare
poweifeng
reviewed
Jun 6, 2025
| : createUbershaderProvider(engine, UBERARCHIVE_DEFAULT_DATA, | ||
| UBERARCHIVE_DEFAULT_SIZE); |
There was a problem hiding this comment.
I think you just want the uber shader here?
There was a problem hiding this comment.
For now yes, but once the issue with non-ubershaders trying to insert spec constants is resolved we will probably switch back. For now I think it makes sense to keep some of that code to bring it back as appropriate?
664f09f to
f8c9eed
Compare
poweifeng
reviewed
Jun 6, 2025
| int opt; | ||
| int option_index = 0; | ||
| // Make WebGPU the default for this test | ||
| app->config.backend = Engine::Backend::WEBGPU; |
There was a problem hiding this comment.
let's not do this unless this sample is meant to be deleted later
There was a problem hiding this comment.
That is my intention actually. I can still remove this if you want, but as far as I see it this sample only exists as a stopgap to enable webgpu development until other issues are resolved.
| : createUbershaderProvider(engine, UBERARCHIVE_DEFAULT_DATA, | ||
| UBERARCHIVE_DEFAULT_SIZE); |
f8c9eed to
ea9818f
Compare
poweifeng
approved these changes
Jun 6, 2025
…itate webgpu development
ea9818f to
a7c047b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.