Added digitalnumbers font including the mentioned fixes: #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support Basic Latin Alphabet
- SIL Open Font License v1.1 with no Reserved Font Name
- Complete Corresponding Source + Build instructions/scripts
|
Woohoo! You did it :) This looks good but there's a few more things to fix. You can leave this pull request open, commit a fixed font file, and git rebase to squash the commits into 1, or if that's too much git gymnastics, close and make a new PR later when we're ready :) |
|
@davelab6 Hope this is ready now :) |
8000
fixes: - Support Basic Latin Alphabet - SIL Open Font License v1.1 with no Reserved Font Name - Complete Corresponding Source + Build instructions/scripts fixed problems reported by dave
|
Forgot |
|
Hello @davelab6 do I miss something here? Or is it ready to merge? |
chrissimpkins
pushed a commit
that referenced
this pull request
Aug 15, 2022
Don' 8000 t delete name IDs which are shared with the STAT table
rsheeter
added a commit
that referenced
this pull request
Aug 18, 2022
774b840 Merge pull request #66 from googlefonts/add_fb 1fef380 For reasons unknown fallbacks don't have spaces in names 6868db7 Update name of fallback per https://github.com/rosettatype/handjet#element-grid-axis-egrd ccc3d9d Add a fallback to egrid ae1828a Merge pull request #57 from vv-monsalve/EGRD-axis f189ea5 EGRD custom axis added 1e0c409 Merge pull request #52 from m4rc1e/nameid25 3dc3626 make family_name optional f81124d Move nameid25 to its own func f2292c3 Merge pull request #50 from m4rc1e/cleanup c6b8f2f tox black: ignore _version.py 4f1b267 update tox 81ba98e black cf07219 fix dependencies 56451de build_fvar_instances: fix typo 1cb8c6d Merge pull request #49 from googlefonts/protect-stat-names 09f11a5 Update __init__.py d980533 Don't delete name IDs which are shared with the STAT table cc74c85 Merge pull request #48 from m4rc1e/vf-names b574137 black a72f81b fix fvar_collision heuristic 678e8b1 add axis ordering 29eae1e add _fvar_instance_collision. e72da38 Merge pull request #47 from googlefonts/items 6c4ee0f AxisRegistry: add items method ad98e3c build_fvar_instances: support fonts which lack wght axis 0a8d5ff actions: publish release added 20cc980 Merge pull request #31 from googlefonts/name-builder 8d78a3b implement simon feedback 78582b0 do not delete name records which are needed elsehwere 82f04c6 do not delete stat name ids if they are used in the fvar table 2859254 Add wonky example 171c100 implement Simon feedback 72de57f simplyify 4e86268 Merge pull request #36 from googlefonts/davelab6-tooltip-fixes f59f1e1 fix replacing names 0f7cc61 add build filename ab3c169 add nameID25 checks dfeec83 add test for style name which is not part of the allowed static fonts bed9a2a replace old family name with new name fb0b17e use enums 3f70b14 clean up 9dc4c88 convert AxisRegistry into a class 06b3633 clean up cf3caf2 add logging a267870 black 2094e52 Add VF tests 243764f refactor name check 6beb90e ignore _version 9a63e46 ignore egg-info b78f091 fix tests 2244460 run black 2d34a35 cleanup stat tests b081509 improve fvar instance checks b9a9b5d add prelim fvar instance check 1ac1758 rm local stuff b2e888f test static name table generation 589f0b9 black d2cbbff add nameID25 449d87d fix vf name table generation for sibling fonts bf9f57d wip linked values ba373db black 23632f9 add build_fvar_instances 7a423c9 wip name builder 948129a Merge pull request #39 from googlefonts/tox 81aa972 run black 15b9f57 update tox 80e36bf weight and width textprotos updated to say stroke weight 796f577 y_transparent_descender.textproto Use depth, not height ed29279 Creating `flair.svg` git-subtree-dir: axisregistry git-subtree-split: 774b840
RosaWagner
pushed a commit
that referenced
this pull request
Nov 16, 2022
set protobuf to use same versions as fontbakery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.