8000 Sigmar: Version 1.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.24] added by emmamarichal · Pull Request #5929 · google/fonts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sigmar: Version 1.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.24] added #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

emmamarichal
Copy link
Collaborator

8fad694: [gftools-packager] Sigmar: Version 1.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.24] added

a40fa74: Sigmar: description added

…;gftools[0.9.24] added

* Sigmar Version 1.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.24] taken from the upstream repo https://github.com/googlefonts/sigmarone at commit googlefonts/sigmarone@1fb4311.
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 1 of them (100.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    [code: summary]


[20] Sigmar-Regular.ttf
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NeWT' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: METADATA.pb: Fontfamily is listed on Google Fonts API? (com.google.fonts/check/metadata/listed_on_gfonts)
  • WARN Family not found via Google Fonts API. [code: not-found]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + f

    • f + l

    • l + f

    • And i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • WARN We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.638x (1638) [code: bad-hhea-range]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • NULL

    • eight.lf

    • five.lf

    • four.lf

    • i.loclTRK.1

    • nine.lf

    • one.lf

    • seven.lf

    • six.lf

    • three.lf

    • And 4 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This font has a 'Soft Hyphen' character (codepoint 0x00AD) which is supposed to be zero-width and invisible, and is used to mark a hyphenation possibility within a word in the absence of or overriding dictionary hyphenation. It is mostly an obsolete mechanism now, and the character is only included in fonts for legacy codepage coverage. [code: softhyphen]
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: a	Contours detected: 3	Expected: 2

- Glyph name: b	Contours detected: 3	Expected: 2

- Glyph name: uni00AD	Contours detected: 1	Expected: 0

- Glyph name: agrave	Contours detected: 4	Expected: 3

- Glyph name: aacute	Contours detected: 4	Expected: 3

- Glyph name: acircumflex	Contours detected: 4	Expected: 3

- Glyph name: atilde	Contours detected: 4	Expected: 3

- Glyph name: adieresis	Contours detected: 5	Expected: 4

- Glyph name: aring	Contours detected: 5	Expected: 4

- Glyph name: amacron	Contours detected: 4	Expected: 3 

- And 89 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
  • WARN No dotted circle glyph present [code: missing-dotted-circle]
WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • K (U+004B): B<<390.0,464.0>-<397.0,471.0>-<396.0,470.0>>/L<<396.0,470.0>--<472.0,545.0>> = 0.3794367014184255

    • R (U+0052): B<<47.5,80.5>-<47.0,102.0>-<48.0,95.0>>/B<<48.0,95.0>-<47.0,108.0>-<45.0,130.0>> = 3.7313969991604012

    • Racute (U+0154): B<<47.5,80.5>-<47.0,102.0>-<48.0,95.0>>/B<<48.0,95.0>-<47.0,108.0>-<45.0,130.0>> = 3.7313969991604012

    • Rcaron (U+0158): B<<47.5,80.5>-<47.0,102.0>-<48.0,95.0>>/B<<48.0,95.0>-<47.0,108.0>-<45.0,130.0>> = 3.7313969991604012

    • b (U+0062): B<<338.0,53.0>-<339.0,55.0>-<338.0,60.0>>/B<<338.0,60.0>-<338.0,56.0>-<338.0,53.0>> = 11.309932474020195

    • cent (U+00A2): L<<339.0,-2.0>--<355.0,0.0>>/L<<355.0,0.0>--<348.0,0.0>> = 7.125016348901757

    • comma (U+002C): B<<88.0,-148.0>-<88.0,-143.0>-<85.0,-143.0>>/B<<85.0,-143.0>-<137.0,-132.0>-<170.0,-88.0>> = 11.944177188446329

    • g (U+0067): L<<158.0,223.0>--<162.0,223.0>>/B<<162.0,223.0>-<139.0,228.0>-<113.0,241.0>> = 12.2647737278924

    • gbreve (U+011F): L<<158.0,223.0>--<162.0,223.0>>/B<<162.0,223.0>-<139.0,228.0>-<113.0,241.0>> = 12.2647737278924

    • gcaron (U+01E7): L<<158.0,223.0>--<162.0,223.0>>/B<<162.0,223.0>-<139.0,228.0>-<113.0,241.0>> = 12.2647737278924

    • And 49 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • Abreve (U+0102): L<<178.0,982.0>--<310.0,981.0>>

    • D (U+0044): L<<347.0,-1.0>--<62.0,1.0>>

    • D (U+0044): L<<365.0,550.0>--<364.0,430.0>>

    • D (U+0044): L<<56.0,671.0>--<172.0,670.0>>

    • Dcaron (U+010E): L<<347.0,-1.0>--<62.0,1.0>>

    • Dcaron (U+010E): L<<365.0,550.0>--<364.0,430.0>>

    • Dcaron (U+010E): L<<56.0,671.0>--<172.0,670.0>>

    • Dcroat (U+0110): L<<120.0,671.0>--<236.0,670.0>>

    • Dcroat (U+0110): L<<411.0,-1.0>--<126.0,1.0>>

    • Dcroat (U+0110): L<<429.0,550.0>--<428.0,430.0>>

    • And 81 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/sigmar/Sigmar-Regular.ttf
Dehinted Size 137.0kb
Hinted Size 204.2kb
Increase 67.2kb
Change 49.1 %
[code: size-impact]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.000; ttfautohint (v1.8.4.7-5d5b);gftools[0.9.24]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/sigmar [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 11 55 10 151 0
0% 0% 5% 24% 4% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator
m4rc1e commented Mar 1, 2023

Any reason why this hasn't been released as Sigmar One?

@emmamarichal
Copy link
Collaborator Author

Yes! :) googlefonts/sigmarone#31 (comment)

@m4rc1e
Copy link
Collaborator
m4rc1e commented Mar 1, 2023

Thanks for the link. All sounds good. Only concern is that by naming it Sigmar, we won't be able to expand it by adding weights since the current Regular is a Black. Happy to merge if others are ok with this.

@emmamarichal
Copy link
Collaborator Author

Ah yes indeed. I can still change that to Regular. @RosaWagner, @davelab6 what do you think?

@RosaWagner
Copy link
Contributor
RosaWagner commented Mar 1, 2023

I have no opinion, I transmitted Dave's decision, but maybe we should talk about it more. cc @chrissimpkins

Context: the problem is that Sigmar One is a small caps font and was not onboarded with "SC" in the family name. So either we call it Sigmar, or Sigmar Heavy / Two / etc.

@m4rc1e
Copy link
Collaborator
m4rc1e commented Mar 1, 2023

The font is Regular, https://github.com/google/fonts/pull/5929/files#diff-e80717af937dc118f9bc8594574a4de67e42bdaf7371634e44fc592bc8823f11R6-R14. The issue is that the current Regular has the appearance of a Black weight. If we release the family as Sigmar in its current state, we won't be able to add a Regular weight in the future.

@RosaWagner RosaWagner added the -- Needs manager's opinion from upper level label Mar 1, 2023
@m4rc1e
Copy link
Collaborator
m4rc1e commented Mar 1, 2023

If we don't plan to extend, I'm happy for it to be released as is.

@RosaWagner RosaWagner merged commit 8852b0a into main Mar 9, 2023
@RosaWagner RosaWagner deleted the gftools_packager_ofl_sigmar branch March 9, 2023 16:53
@RosaWagner RosaWagner added --- Live Font is visible on API and removed --- to production labels Apr 26, 2023
@RosaWagner RosaWagner removed the --- Live Font is visible on API label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Upgrade Sigmare One [Summer of Type]
3 participants
0