-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Noto Sans Syriac Western: Version 3.000 added #9416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/notofonts/syriac at commit notofonts/syriac@0be4b71.
FontBakery reportfontbakery version: 0.13.2 Check results[22] NotoSansSyriacWestern[wght].ttf🔥 FAIL Combined length of family and style must not exceed 32 characters. name/family_and_style_max_length
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
🔥 FAIL Does DESCRIPTION file contain broken links? googlefonts/description/broken_links
|
ofl/notosanssyriacwestern/NotoSansSyriacWestern[wght].ttf | |
---|---|
Dehinted Size | 171.7kb |
Hinted Size | 171.7kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.000']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 13 | 40 | 7 | 173 | 0 |
0% | 0% | 1% | 6% | 17% | 3% | 73% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Hi @simoncozens! Otherwise, I have doubts about the following ones, but some of them are probably intentional, I'm just checking!
|
FontBakery reportfontbakery version: 1.0.0 Check results[22] NotoSansSyriacWestern[wght].ttf🔥 FAIL Combined length of family and style must not exceed 32 characters. name/family_and_style_max_length
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
🔥 FAIL Shapes languages in all GF glyphsets. googlefonts/glyphsets/shape_languages
🔥 FAIL Does DESCRIPTION file contain broken links? googlefonts/description/broken_links
|
ofl/notosanssyriacwestern/NotoSansSyriacWestern[wght].ttf | |
---|---|
Dehinted Size | 171.7kb |
Hinted Size | 171.7kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables? required_tables
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field. googlefonts/metadata/minisite_url
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? googlefonts/gasp
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges]ℹ️ INFO Font has old ttfautohint applied? googlefonts/old_ttfautohint
- ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.000']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table. googlefonts/STAT/axis_order
- ℹ️ INFO
None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 13 | 40 | 7 | 173 | 0 |
0% | 0% | 1% | 6% | 17% | 3% | 73% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
The Latin is OK - companion Latins in Noto fonts are not meant to be comprehensive, they're just there for GF support. The weights are a bit of a problem; I was trying to avoid using an alternate layer. I'll re-do it. |
Taken from the upstream repo https://github.com/notofonts/syriac at commit notofonts/syriac@0be4b71.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectstags
are added for NEW FONTSprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.