This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Address review comments for Bazel/Win32 build #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses strip_include_prefix to avoid leaking private headers (config.h, port.h). This needs a workaround to prevent a "missing dependency declarations" error.
The only macro referenced by the public headers is GOOGLE_GLOG_DLL_DECL. This means fewer defines are propagated to rules that depend on glog.
|
Another user reported that this works for them, so I'll merge. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents leaking
config.hand some unnecessary defines to rules that depend on glog. It also adds a caveat about not supporting thenamespaceparameter.@skeptic-monkey, could you check that these changes work with your use case?