8000 Use PathEscape on search query instead of QueryEscape by gmlewis · Pull Request #966 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use PathEscape on search query instead of QueryEscape #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2018
Merged

Use PathEscape on search query instead of QueryEscape #966

merged 2 commits into from
Aug 8, 2018

Conversation

gmlewis
Copy link
Collaborator
@gmlewis gmlewis commented Aug 5, 2018

Fixes #963.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 5, 2018
@gmlewis
Copy link
Collaborator Author
gmlewis commented Aug 5, 2018

Hmmm... Go 1.7 does not have url.PathEscape apparently.
Shall we stop supporting Go 1.7 ?

@gmlewis
Copy link
Collaborator Author
gmlewis commented Aug 5, 2018

@willnorris, @dmitshur, @juliaferraioli - I'm considering removing support for Go 1.7 for this repo due to it missing url.PathEscape...
Are there any objections?

@gmlewis gmlewis mentioned this pull request Aug 5, 2018
Merged
@gmlewis gmlewis requested a review from juliaferraioli August 7, 2018 01:56
juliaferraioli
juliaferraioli approved these changes Aug 8, 2018
View reviewed changes
Copy link
Contributor
@juliaferraioli juliaferraioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describ 8000 e this comment to others. Learn more.

LGTM, thanks @gmlewis!

@gmlewis
Copy link
Collaborator Author
gmlewis commented Aug 8, 2018

Thank you, @juliaferraioli!
Merging.

@gmlewis gmlewis merged commit 8c40ff4 into google:master Aug 8, 2018
@gmlewis gmlewis deleted the search-query-escape branch August 8, 2018 17:56
gmlewis added a commit to gmlewis/go-github that referenced this pull request Aug 10, 2018
@gmlewis
Use PathEscape on search query instead of QueryEscape (google#966)
9707ab9 
Fixes google#963.
This was referenced Feb 20, 2019
Merged
Closed
@gmlewis gmlewis mentioned this pull request Aug 29, 2019
Closed
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@gmlewis
Use PathEscape on search query instead of QueryEscape (google#966)
54afc93 
Fixes google#963.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaferraioli juliaferraioli juliaferraioli approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmlewis @juliaferraioli @googlebot
0