8000 Add RequestedTeam to PullRequestEvent by kjmancuso · Pull Request #1169 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add RequestedTeam to PullRequestEvent #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2019
Merged

Add RequestedTeam to PullRequestEvent #1169

merged 1 commit into from
May 11, 2019

Conversation

kjmancuso
Copy link
Contributor
@kjmancuso kjmancuso commented May 11, 2019 •
edited
Loading

Adds RequestedTeam to the PullRequestEvent event type.

In the event that a Team is requested for a review instead of a User, it will replace the requested_reviewer in the JSON payload with requested_team.

This allows for reusing similar logic employed when consuming RequestedReviewer without having to iterate through PullRequest.RequestedTeams which could potentially cause duplication events without additional logic.

Tested with Github Enterprise 2.15.9.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label May 11, 2019
@kjmancuso
Copy link
Contributor Author

Since this was a pretty trivial change, apologies in advance if I missed something basic.

@codecov
Copy link
codecov bot commented May 11, 2019 •
edited
Loading

Codecov Report

Merging #1169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1169   +/-   ##
======================================
  Coverage    70.2%   70.2%           
======================================
  Files          84      84           
  Lines        5830    5830           
======================================
  Hits         4093    4093           
  Misses        952     952           
  Partials      785     785
Impacted Files Coverage Δ
github/event_types.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2672b1...5b03bb8. Read the comment docs.

gmlewis
gmlewis approved these changes May 11, 2019
View reviewed changes
Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kremlinkev!
LGTM.
Merging.

@gmlewis gmlewis merged commit 2680886 into google:master May 11, 2019
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
@gmlewis
Add RequestedTeam to PullRequestEvent (google#1169)
e8747f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjmancuso @gmlewis @googlebot
0