8000 Fix update-urls unit tests broken by #1875 by gmlewis · Pull Request #2058 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix update-urls unit tests broken by #1875 #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privac 8000 y statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2021
Merged

Fix update-urls unit tests broken by #1875 #2058

merged 2 commits into from
Aug 21, 2021

Conversation

gmlewis
Copy link
Collaborator
@gmlewis gmlewis commented Aug 21, 2021

Fixes: #2056.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Aug 21, 2021
@codecov
Copy link
8000
codecov bot commented Aug 21, 2021 •
edited
Loading

Codecov Report

Merging #2058 (66bb675) into master (da933ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2058   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files         107      107           
  Lines        9600     9600           
=======================================
  Hits         9384     9384           
  Misses        150      150           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da933ae...66bb675. Read the comment docs.

@gmlewis gmlewis requested a review from wesleimp August 21, 2021 15:34
@gmlewis gmlewis merged commit a0448fc into google:master Aug 21, 2021
@gmlewis gmlewis deleted the update-update-urls branch August 21, 2021 15:37
@gmlewis gmlewis mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bslewis721 bslewis721 bslewis721 approved these changes

@wesleimp wesleimp Awaiting requested review from wesleimp

Assignees
No one assigned
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestParseWebPageEndpoints_ActivityEvents panics: cannot handle unexported field at {*main.Endpoint}.endpointName:
2 participants
@gmlewis @bslewis721
0