8000 Add support for the secret scanning API by jcrqr · Pull Request #2281 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for the secret scanning API #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and priv 8000 acy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 4, 2022

Conversation

jcrqr
Copy link
Contributor
@jcrqr jcrqr commented Feb 3, 2022

This PR adds support for the Secret Scanning API. Includes all endpoints and structures listed on the API documentation.

Closes #2278

Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @crqra !

@codecov
Copy link
codecov bot commented Feb 3, 2022

Codecov Report

Merging #2281 (000bc40) into master (e1c28bc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
+ Coverage   97.81%   97.83%   +0.01%     
==========================================
  Files         114      115       +1     
  Lines       10266    10357      +91     
==========================================
+ Hits        10042    10133      +91     
  Misses        156      156              
  Partials       68       68              
Impacted Files Coverage Δ
github/github.go 97.63% <100.00%> (+<0.01%) ⬆️
github/secret_scanning.go 100.00% <100.00%> (ø)
github/event_types.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c28bc...000bc40. Read the comment docs.

@jcrqr jcrqr requested a review from gmlewis February 3, 2022 18:04
@gmlewis gmlewis changed the title feat: add support for the secret scanning API Add support for the secret scanning API Feb 3, 2022
@jcrqr
Copy link
Contributor Author
jcrqr commented Feb 3, 2022

Thanks for the feedback @gmlewis! I've updated the PR with your suggestions, LMK if it looks good 😄

Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @crqra !
LGTM.
Awaiting second LGTM/Approval before merging.

@gmlewis
Copy link
Collaborator
gmlewis commented Feb 4, 2022

@Parker77 - do you have time to review this PR?

Copy link
@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gmlewis
Copy link
Collaborator
gmlewis commented Feb 4, 2022

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit a842efc into google:master Feb 4, 2022
@jcrqr jcrqr deleted the feat/secret-scanning-api branch February 4, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Secret Scanning endpoints
3 participants
0