Update readme to include go-githubauth for Application auth #3180
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3180 +/- ##
==========================================
- Coverage 97.72% 92.93% -4.79%
==========================================
Files 153 171 +18
Lines 13390 11542 -1848
==========================================
- Hits 13085 10727 -2358
- Misses 215 724 +509
- Partials 90 91 +1 ☔ View full report in Codecov by Sentry. |
README.md
Outdated
| return | ||
| } | ||
|
|
||
| installationTokenSource := githubauth.NewInstallationTokenSource(20, appTokenSource) |
There was a problem hiding this comment.
According to this: https://github.com/jferrl/go-githubauth/blob/main/auth.go#L52
the first argument is id string so the 20 here looks weird.
There was a problem hiding this comment.
I've updated the code to be aligned with go-github ids representation. Now both ids are defined as int64. Also changed the readme go code examples.
There was a problem hiding this comment.
Just FYI - your README.md still needs to be updated - not a biggie - just wanted to let you know. 😄
https://github.com/jferrl/go-githubauth/blob/main/README.md?plain=1#L48-L51
There was a problem hiding this comment.
Sure! Im working on it! thanks!
Fixes: #3178.
This PR includes some README changes to include references of a new pkg to authenticate application and installation requests.