Update security manager operations to use organization roles REST APIs #3418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3418 +/- ##
==========================================
- Coverage 97.72% 92.19% -5.53%
==========================================
Files 153 173 +20
Lines 13390 14949 +1559
==========================================
+ Hits 13085 13782 +697
- Misses 215 1072 +857
- Partials 90 95 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The organization security manager role REST APIs are being sunset (https://gh.io/security-managers-rest-api-sunset) in favor of the organization roles REST APIs.
Instead of introducing a breaking change by removing the operations from go-github, this PR updates the operations to use the organization roles REST APIs so consumers (such as Terraform) can continue to manage organization security manager teams without needing to change code.