8000 feat: Add EPSS to Dependabot alerts by mdfleury-wbd · Pull Request #3547 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add EPSS to Dependabot alerts #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025

Conversation

mdfleury-wbd
Copy link
Contributor

Adding new field with EPSS information to Dependabot alerts

Copy link
google-cla bot commented Apr 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mdfleury-wbd!
Do you have a link that would give people more information about those new fields and how to interpret them that you could add to the comments?

Copy link
codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (3a3f51b) to head (515415e).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3547      +/-   ##
==========================================
- Coverage   91.29%   91.23%   -0.07%     
==========================================
  Files         184      183       -1     
  Lines       16169    16053     -116     
==========================================
- Hits        14762    14646     -116     
  Misses       1231     1231              
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdfleury-wbd
Copy link
Contributor Author

Thank you, @mdfleury-wbd! Do you have a link that would give people more information about those new fields and how to interpret them that you could add to the comments?

I do

https://github.blog/changelog/2024-10-10-epss-scores-in-the-github-advisory-database/

Any preference as to where in the comments?

Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like this?

@gmlewis gmlewis changed the title Feat: Add EPSS to Dependabot alerts feat: Add EPSS to Dependabot alerts Apr 14, 2025
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@mdfleury-wbd mdfleury-wbd requested a review from gmlewis April 14, 2025 18:18
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis
Copy link
Collaborator
gmlewis commented Apr 15, 2025

Please run go generate ./... (or ./script/generate.sh) one more time and push the results.

@gmlewis
Copy link
Collaborator
gmlewis commented Apr 15, 2025

Oh, sorry, it looks like a test needs updating (remove the two Ptr() calls).

Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mdfleury-wbd!
LGTM.
Merging.

(It looks like Codecov is currently having problems which is causing the tests to fail, but I pulled this PR locally and tested it and it all looks good, so merging anyway.)

@gmlewis gmlewis merged commit 6a7684f into google:master Apr 15, 2025
2 of 8 checks passed
@mdfleury-wbd mdfleury-wbd deleted the add-dependabot-epss branch April 15, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0