8000 feat!: Add repository query option to ListCustomPropertyValues by kazuki-hanai · Pull Request #3598 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat!: Add repository query option to ListCustomPropertyValues #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2025
Merged

feat!: Add repository query option to ListCustomPropertyValues #3598

merged 3 commits into from
Jun 24, 2025

Conversation

kazuki-hanai
Copy link
Contributor
@kazuki-hanai kazuki-hanai commented Jun 24, 2025 •
edited by gmlewis
Loading

BREAKING CHANGE: ListCustomPropertyValues now takes ListCustomPropertyValuesOptions instead of ListOptions.

Fixes: #3596

What

SSIA

Why

I want to use repository_query option for OrganizationService. ListCustomPropertyValues.

related issue: #3596

@google-cla Google CLA
Copy link
google-cla bot commented Jun 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kazuki-hanai kazuki-hanai mentioned this pull request Jun 24, 2025
Closed
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Jun 24, 2025
@codecov Codecov
Copy link
codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (ad671c4) to head (d3d65e6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         184      184           
  Lines       16143    16143           
=======================================
  Hits        14742    14742           
  Misses       1227     1227           
  Partials      174      174

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gmlewis
gmlewis approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kazuki-hanai!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@stevehipwell or @alexandear - might one of you have time for a code review? Thank you!

alexandear
alexandear reviewed Jun 24, 2025
View reviewed changes
kazuki-hanai and others added 2 commits June 24, 2025 21:29
@kazuki-hanai @alexandear
Update github/orgs_properties.go
06ac6a5 
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
@kazuki-hanai
Rename CustomPropertyValuesListOptions to ListCustomPropertyValuesOpt…
d3d65e6 
…ions for consistent naming
@kazuki-hanai
Copy link
Contributor Author

@alexandear Thank you for your review!
I fixed other in d3d65e6

stevehipwell
stevehipwell approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jun 24, 2025
@gmlewis
Copy link
Collaborator
gmlewis commented Jun 24, 2025

Thank you, @alexandear and @stevehipwell!
LGTM.
Merging.

@gmlewis gmlewis changed the title Add repository query option to ListCustomPropertyValues feat!: Add repository query option to ListCustomPropertyValues Jun 24, 2025
@gmlewis gmlewis merged commit 1b8d6fb into google:master Jun 24, 2025
7 checks passed
@gmlewis gmlewis mentioned this pull request Jun 24, 2025
Merged
@kazuki-hanai kazuki-hanai deleted the introduce-repo-query branch June 25, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear left review comments

@stevehipwell stevehipwell stevehipwell approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why repository_query option haven't been implemented?
4 participants
@kazuki-hanai @gmlewis @alexandear @stevehipwell
0