feat: make TypeVisitor public (#7838) #7845
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsocv12
reviewed
Jun 30, 2025
| - Under "Use compiler," select **Javac with custom path** | ||
| - Provide the path to the downloaded `error_prone_core-xxx.jar` | ||
|
|
||
| > 🔧 Note: If you don't configure Error Prone correctly, you may face errors like: |
| @@ -54,7 +54,7 @@ | |||
| * | |||
| * @author Ben Yu | |||
| */ | |||
| abstract class TypeVisitor { | |||
| public abstract class TypeVisitor { | |||
There was a problem hiding this comment.
If this is going to be make public we need to ad JDoc
There was a problem hiding this comment.
Not sure if we want to add this to the readme
There was a problem hiding this comment.
You have another PR #7844 with this change please remove from this one
|
Hi @Aarshpatel12. Thanks for this PR. Please wait until we've decided to accept the feature request #7838. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly explain you’re making TypeVisitor public as requested in issue #7838.