Start TCP dispatchers after endpoints are completely loaded during restore. #11743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6e5b8de to
029eb66
Compare
…store. - During restore if endpoints' states are not loaded before starting dispatchers, then the incoming packets will be queued and the dispatcher will try to send the packets, which will result in a panic as the endpoint might still be in an invalid state (eg: initial). - To avoid this, wait for all the endpoints to be loaded completely before starting the dispatchers by calling AsycnLoading.Wait() in stack.Restore() and remove this from kernel.LoadFrom() - Added a test to check save restore of multiple(100) listening sockets. PiperOrigin-RevId: 762010964
029eb66 to
8980842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start TCP dispatchers after endpoints are completely loaded during restore.
dispatchers, then the incoming packets will be queued and the dispatcher will
try to send the packets, which will result in a panic as the endpoint might
still be in an invalid state (eg: initial).
starting the dispatchers by calling AsycnLoading.Wait() in stack.Restore() and
remove this from kernel.LoadFrom()