8000 Temporarily fix the Audience Segmentation oAuth Setup being interrupted by another banner in queue · Issue #10903 · google/site-kit-wp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Temporarily fix the Audience Segmentation oAuth Setup being interrupted by another banner in queue #10903
Open
@jimmymadon

Description

@jimmymadon

Bug Description

This issue is created to track a temporary fix to #10890 which will require a more holistic solution.

Steps to reproduce

See issue #10890


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The Audience Segmentation Setup CTA Widget as well as the Enhanced Measurement Banner, that consist of a page reload (e.g. to take the user to oAuth) between multiple "steps" should always load its latter steps fully until that notification is actioned.

Implementation Brief

  • Decrease the priority of the notifications in the AC to 210 and 220.

Test Coverage

  • No new tests required.

QA Brief

  • On a new or existing site, connect a GA4 property where Enhanced Measurement is disabled. Also, either use a property without Site Kit audiences or mock this using the option available in the tester plugin.
    • Delete the wp_googlesitekit_additional_auth_scopes row in the wp_usermeta table again. Now refresh the dashboard and the Audience Segmentation setup CTA will be displayed. Ensure it works normally now and AS is setup successfully after going through the oAuth flow.
  • Delete the wp_googlesitekit_additional_auth_scopes row in the wp_usermeta table again.
  • Refresh the dashboard, and the Enhanced Measurement Setup CTA should appear. Verify the Enhanced Measurement setup is done correctly.

Changelog entry

  • Fix bug that could cause auth setup banners to be interrupted by another notification.

Metadata

Metadata

Labels

P0High priorityTeam MIssues for Squad 2Team SIssues for Squad 1Type: BugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0