8000 pkg/cover: several fixes by eaibmz · Pull Request #6127 · google/syzkaller · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pkg/cover: several fixes #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2025
Merged

pkg/cover: several fixes #6127

merged 2 commits into from
Jun 30, 2025

Conversation

eaibmz
Copy link
Contributor
@eaibmz eaibmz commented Jun 25, 2025 •
edited
Loading

The function CleanPath() cannot handle symbolic links within syz-manager's paths to kernel directories because the DWARF backend returns paths to kernel source files with symbolic links resolved.

objdump prints absolute addresses for coverage points of core kernel.

@eaibmz eaibmz force-pushed the s390x-upstream-fixes branch from 3a44875 to 0c63551 Compare June 25, 2025 08:13
@eaibmz
Copy link
Contributor Author
eaibmz commented Jun 25, 2025

Another option would be to resolve the symbolic links in CompleteKernelDirs() for everyone, not only cover.
I can update the fix in case you want to go with this alternative.

@eaibmz eaibmz force-pushed the s390x-upstream-fixes branch from 0c63551 to fa5591d Compare June 25, 2025 08:54
@eaibmz eaibmz changed the title pkg/cover: fix handling of symlinks in kernel paths of dwarf backend pkg/cover: fix handling of symlinks in kernel paths of dwarf backend and coverage pont pc in core kernel Jun 25, 2025
a-nogikh
a-nogikh reviewed Jun 25, 2025
View reviewed changes
@eaibmz eaibmz changed the title pkg/cover: fix handling of symlinks in kernel paths of dwarf backend and coverage pont pc in core kernel pkg/cover: several fixes Jun 26, 2025
@eaibmz eaibmz force-pushed the s390x-upstream-fixes branch from 014c937 to 51b5e37 Compare June 30, 2025 12:36
@eaibmz
pkg/cover: fix coverage point pc for core kernel
e5a7d02 
objdump prints absolute addresses for coverage points of core kernel.

Signed-off-by: Alexander Egorenkov <eaibmz@gmail.com>
@eaibmz eaibmz force-pushed the s390x-upstream-fixes branch from 51b5e37 to d8f1339 Compare June 30, 2025 12:38
@eaibmz
pkg/cover: extract coverage points from binary data for s390x arch
0f36a17 
This is a faster way to find all coverage points.

Signed-off-by: Alexander Egorenkov <eaibmz@gmail.com>
@eaibmz eaibmz force-pushed the s390x-upstream-fixes branch from d8f1339 to 0f36a17 Compare June 30, 2025 12:46
a-nogikh
a-nogikh approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator
@a-nogikh a-nogikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a-nogikh a-nogikh added this pull request to the merge queue Jun 30, 2025
Merged via the queue into google:master with commit 43d64ae Jun 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-nogikh a-nogikh a-nogikh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eaibmz @a-nogikh
0