refactor(io): Refactor network types into net::io modules, add runtime fallback for-uring #1191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
approved these changes
Mar 28, 2025
They will be aware because we log an error when io-uring fails, so they see that it failed. |
d6f914d to
069cdeb
Compare
|
Build Failed 😭 Build Id: f122d74e-f3e1-492f-a3f4-d1bbd4059ceb Status: FAILURE To get permission to view the Cloud Build view, join the quilkin-discuss Google Group. Filter with the Git Commit Development images are retained for at least 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1183 by refactoring the network listening code to allow for falling all the way back to epoll on Linux at runtime.
As part of that I've consolidated all our different IO backends into a single
net::iomodule, and then I made a module for each of our different kinds of backends (polling, completion, NIC) and moved platform specific code there, that way more of the code can be compiled on macOS and Windows which makes development easier with more of the logic being shared.This should be a bit tidier with #1185 but I wanted to fix #1183 first.