go.mod: upgrade dependencies and rid vulnerable thrift version@v0.12.0 #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mikehelmick, once this PR is hopefully merged and a new release is cut, I'll then update our dependencies and that should remove that transitive dependency. |
dhui
requested changes
Jul 26, 2020
Coming here, after digging through google/exposure-notifications-server#749 in which the version of github.com/apache/thrift was reported by @whaber as having known critical vulnerabilities. Transitively however, this version was pinning to cloud.google.com/go@v0.37.4 indirectly, which then imported versions of opencensus: * go.opencensus.io@v0.19. * go.opencensus.io@v0.20.1 that imported github.com/apache/thrift@v0.12.0 The target package to upgrade was github.com/denisenkom/go-mssqldb v0.0.0-20200620013148-b91950f658ec which now uses cloud.google.com/go@v0.61.0
|
Thanks @dhui for the initial review! I've made a conservative update to only github.com/denisenkom/go-mssqldb@v0.0.0-20200620013148-b91950f658ec which then doesn't touch the Gitlab client. Let's see if that works. |
|
Thank you for the merge! Please help cut a release that’ll then be used by
various go.mod dependent projects. Thank you.
…On Sun, Jul 26, 2020 at 11:18 PM Dale Hui ***@***.***> wrote:
Merged #417 <#417> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#417 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3V4PZXUATM4A3VMN3QDR5UL4PANCNFSM4PHX3AVA>
.
|
|
Done: v4.12.0 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming here, after digging through
google/exposure-notifications-server#749
in which the version of github.com/apache/thrift was reported by
@whaber as having known critical vulnerabilities.
Transitively however, this version was pinning to
cloud.google.com/go@v0.37.4 indirectly, which then imported
versions of opencensus:
that imported
github.com/apache/thrift@v0.12.0