8000 Redact passwords by joelazar · Pull Request #1286 · golang-migrate/migrate · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Redact passwords #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Redact passwords #1286

wants to merge 2 commits into from

Conversation

joelazar
Copy link

Found the following problem today with this package:

When sending an invalid URL as a database URL to the package, the entire URL, including any kind of secrets, is included in the errors.

I made the following change to address this. Let me know what you think 👍

It was mentioned here and here too.

@coveralls
Copy link

Coverage Status

coverage: 56.389% (+0.08%) from 56.314%
when pulling bbb22bd on joelazar:feat/redact-password
into 2788339 on golang-migrate:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
4F64
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelazar @coveralls
0