10000 test: unset GIT_DIR for git operations in integration tests by sigma · Pull Request #1868 · golang/dep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

test: unset GIT_DIR for git operations in integration tests #1868

Merged
merged 1 commit into from
Jul 3, 2018
Merged

test: unset GIT_DIR for git operations in integration tests #1868

merged 1 commit into from
Jul 3, 2018

Conversation

sigma
Copy link
Contributor
@sigma sigma commented May 18, 2018

What does this do / why do we need it?

This allows integration tests to run during git rebase operations.
Without this, GIT_DIR points to the dep repo itself, which makes git checkout
operations fail miserably.

$ GOCACHE=off git rebase -x "go test github.com/golang/dep/cmd/dep -run TestIntegration/ensure/add/desync" 'HEAD^'
Executing: go test github.com/golang/dep/cmd/dep -run TestIntegration/ensure/add/desync
--- FAIL: TestIntegration (0.01s)
    --- FAIL: TestIntegration/ensure/add/desync (0.00s)
        --- FAIL: TestIntegration/ensure/add/desync/internal (2.79s)
        	testcase.go:165: error raised where none was expected: 
        		(1/1) github.com/sdboyer/deptesttres@master
        		
        		Root project is "github.com/golang/notexist"
        		 1 transitively valid internal packages
        		 3 external packages imported from 3 projects
        		(0)   ✓ select (root)
        		(1)	? attempt github.com/sdboyer/deptesttres with 1 pkgs; at least 1 versions to try
        		(1)	    try github.com/sdboyer/deptesttres@master
        		(1)	✗   unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		(1)	  : command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        		(1)	    try github.com/sdboyer/deptesttres@master
        		(1)	✗   unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		(1)	  : command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        		(1)	  ← no more versions of github.com/sdboyer/deptesttres to try; begin backtrack
        		  ✗ solving failed
        		
        		Solver wall times by segment:
        		     b-list-versions: 773.290367ms
        		         b-list-pkgs:   6.983762ms
        		         select-root:    107.395µs
        		            new-atom:     58.489µs
        		             satisfy:     37.263µs
        		  b-deduce-proj-root:     11.902µs
        		               other:     10.495µs
        		     b-source-exists:      2.847µs
        		
        		  TOTAL: 780.50252ms
        		
        		Solving failure: No versions of github.com/sdboyer/deptesttres met constraints:
        			master: unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		: command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        			master: unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		: command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        --- FAIL: TestIntegration/ensure/add/desync/external (3.40s)
        	testcase.go:165: error raised where none was expected: 
        		(1/1) github.com/sdboyer/deptesttres@master
        		
        		Root project is "github.com/golang/notexist"
        		 1 transitively valid internal packages
        		 3 external packages imported from 3 projects
        		(0)   ✓ select (root)
        		(1)	? attempt github.com/sdboyer/deptesttres with 1 pkgs; at least 1 versions to try
        		(1)	    try github.com/sdboyer/deptesttres@master
        		(1)	✗   unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		(1)	  : command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        		(1)	    try github.com/sdboyer/deptesttres@master
        		(1)	✗   unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		(1)	  : command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        		(1)	  ← no more versions of github.com/sdboyer/deptesttres to try; begin backtrack
        		  ✗ solving failed
        		
        		Solver wall times by segment:
        		     b-list-versions: 1.336373581s
        		         b-list-pkgs:   5.263873ms
        		         select-root:    142.784µs
        		             satisfy:     63.792µs
        		            new-atom:     63.545µs
        		               other:     10.724µs
        		  b-deduce-proj-root:     10.516µs
        		     b-source-exists:      2.346µs
        		
        		  TOTAL: 1.341931161s
        		
        		Solving failure: No versions of github.com/sdboyer/deptesttres met constraints:
        			master: unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		: command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
        			master: unable to update checked out version: fatal: reference is not a tree: 54aaeb0023e1f3dcf5f98f31dd8c565457945a12
        		: command failed: [git checkout 54aaeb0023e1f3dcf5f98f31dd8c565457945a12]: exit status 128
FAIL
FAIL	github.com/golang/dep/cmd/dep	5.453s
warning: execution failed: go test github.com/golang/dep/cmd/dep -run TestIntegration/ensure/add/desync
You can fix the problem, and then run

  git rebase --continue

What should your reviewer look out for in this PR?

Do you need help or clarification on anything?

Which issue(s) does this PR fix?

@sigma
test: unset GIT_DIR for git operations in integration tests
afa687f 
This allows integration tests to run during git rebase operations.
Without this, GIT_DIR points to the dep repo itself, which makes git checkout
operations fail miserably.
@sigma sigma requested a review from sdboyer as a code owner May 18, 2018 20:05
@sigma sigma mentioned this pull request May 22, 2018
Merged
@sdboyer sdboyer merged commit a437df4 into golang:master Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdboyer sdboyer Awaiting requested review from sdboyer sdboyer is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigma @sdboyer @googlebot
0