10000 Improve Actions workflows, fix tests on CI by dometto · Pull Request #1903 · gollum/gollum · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Actions workflows, fix tests on CI #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 8, 2022
Merged

Improve Actions workflows, fix tests on CI #1903

merged 14 commits into from
Dec 8, 2022

Conversation

dometto
Copy link
Member
@dometto dometto commented Dec 6, 2022

No description provided.

@dometto
Copy link
Member Author
dometto commented Dec 6, 2022

This is to avoid the double running of tests when a new PR is opened, which apparently triggers both the push and pull_requests events. Fix is (hopefully) to run tests only on pushes to the master branch specifically.

As a bonus, add node_modules to .gitignore.

Seems to be working now (after failed attempt in #1902), but the tests are currently failing for different reasons.

@dometto dometto mentioned this pull request Dec 6, 2022
Merged
@benjaminwil benjaminwil mentioned this pull request Dec 6, 2022
Merged
@benjaminwil
Copy link
Member

Looks like I won't be able to push to your branch after all.

But if you cherry-pick this commit: d431cc7, we are down to just JRuby and Selenium failures. ✨

@dometto dometto changed the title Improve actions Improve Actions workflows, fix tests on CI Dec 7, 2022
@dometto
Copy link
Member Author
dometto commented Dec 7, 2022

There's a JRuby bug with the latest version of psych: ruby/psych#598

@headius
Copy link
headius commented Dec 7, 2022

The psych bug is a release problem; the 5.0 gem was shipped with a pre-5.0 jar extension. I have updated the related issue.

@headius
Copy link
headius commented Dec 8, 2022

Psych 5.0.1 has been released, fixing the _native_parse issue.

@benjaminwil
Copy link
Member

@headius Thanks for letting us know. 🙏 Have a great week.

@dometto dometto merged commit 506f9d6 into gollum:master Dec 8, 2022
@dometto dometto deleted the improve_actions2 branch December 8, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dometto @benjaminwil @headius
0