Update docker-deploy.yml: don't trigger on push to master #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging #2094, the precompile-assets worklow will trigger docker-deploy. To avoid duplicate runs of this workflow, we can remove the push-to-master trigger here.
benjaminwil
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
I wasn't following along on the new precompile assets workflow work, so thanks for explaining the different workflow run cases.
I feel like there may be an opportunity to rename or restructure these workflows in the future... at a big-picture level, I am not sure why precompiling assets should trigger a Docker deploy. It is only when I look closely at the workflows that it starts to make sense.
I think the more semantic root workflow would be the "release" named workflow. We need Docker deploys and precompiled assets for releases, and between releases we have the unstable release which is the head of the master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #2094, the precompile-assets workflow will trigger docker-deploy. To avoid duplicate runs of this workflow, we can remove the push-to-master trigger here.
So at present the workflow logic looks as follows:
master: triggersprecompile-asset, which triggersdocker-deploydocker-deploy, but notprecompile-assets.Would appreciate a quick check if this makes sense!