Fix some bug #711
Fix some bug #711
Conversation
change BlockState#detectFromPlacement signature fix Trapdoor add HalfBlockState
Add ItemStainedGlass color state
Add Wool#drops
fix ItemFenceGate bug
|
|
| @@ -1,6 +1,7 @@ | |||
| package io.gomint.inventory.item; | |||
There was a problem hiding this comment.
This should be moved to ItemGlass since there is no "stained" and "non-stained" version.
| @@ -1,6 +1,7 @@ | |||
| package io.gomint.inventory.item; | |||
There was a problem hiding this comment.
This should be moved to ItemGlassPane since there is no "stained" and "non-stained" version.
|
Also please fill in the docs. I won't merge API filled with documentation Todos |
|
|
||
|
|
||
| //TODO: docs | ||
| Facing face(); |
There was a problem hiding this comment.
There is a BlockFacing abstraction interface. Please use it
| @@ -53,4 +54,9 @@ | |||
| */ | |||
| BlockBed head(boolean value); | |||
|
|
|||
| //TODO: docs | |||
| Direction face(); | |||
There was a problem hiding this comment.
There is a BlockFacing abstraction interface. Please use it
| @@ -7,7 +7,6 @@ | |||
| * @author geNAZt | |||
| * @version 1.0 | |||
| */ | |||
| @RegisterInfo( sId = "minecraft:leaves2") | |||
There was a problem hiding this comment.
Why has this register been removed but not the implementation class? There is currently no way to use this and the API class on it
|
|
||
| @Override | ||
| public io.gomint.inventory.item.ItemStainedGlassPane color(GlassColor color) { | ||
| this.data((short) color.ordinal()); |
There was a problem hiding this comment.
Since the transparent has been merged to the end it would result in invalid data. Please handle that case different. Also you need to change the material here to glass_pane
| @@ -84,7 +84,7 @@ public Bearing opposite() { | |||
| */ | |||
| public static Bearing fromAngle( float angle ) { | |||
| // Normalize angle | |||
| angle -= 90; | |||
| angle += 180;// Why -90? | |||
There was a problem hiding this comment.
180 also is wrong. best would be to change north and south in the if statements below and getting rid of any further angle manipulation.
Also this seems to be correct, i have cross checked it with the way JE coordinate system works. And its the same for bedrock it seems
| } | ||
| // @Override | ||
| // public String blockId() { | ||
| // return "minecraft:stained_glass"; |
There was a problem hiding this comment.
We use git, please delete commented code
No description provided.