8000 Bump Gosling.js to `v1.0.2` by gosling-bot[bot] · Pull Request #171 · gosling-lang/gos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump Gosling.js to v1.0.2 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Bump Gosling.js to v1.0.2 #171

merged 2 commits into from
Apr 28, 2025

Conversation

gosling-bot[bot]
Copy link
@gosling-bot gosling-bot bot commented Apr 25, 2025

Automated PR. Update binding for Gosling.js v1.0.2.

@gosling-bot gosling-bot bot force-pushed the create-pull-request/patch branch from eae3cf8 to c062c69 Compare April 25, 2025 13:46
@sehilyi
Copy link
Member
sehilyi commented Apr 25, 2025

@manzt, What is the recommended way to test changes locally? Also, could you remind me how to open the doc locally?

@manzt
Copy link
Member
manzt commented Apr 25, 2025 •
edited
Loading

@sehilyi we have tests that run in CI, but you can check out this branch (e.g., with the GitHub CLI).

gh pr checkout 171

Make sure you have uv and Deno installed (see README).

You then run tests locally with:

uv run pytest

Open the notebooks in examples/:

uv run jupyter lab

Build and look at the docs:

uv run docs/build.py
uv run python -m http.server -d docs/dist

@manzt
Copy link
Member
manzt commented Apr 25, 2025 •
edited
Loading

@sehilyi I wrote up the above guide in #172

sehilyi
sehilyi reviewed Apr 28, 2025
View reviewed changes
docs/getting_started/installation.rst
.. code-block:: bash

$ pip install -e '.[dev]'
The `gos source repository`_ is available on GitHub. Please read its [README.md](https://github.com/gosling-lang/gos?tab=readme-ov-file#development) for development guidelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the doc still mentions pip while we use uv. I just pointed to the README.md of the GitHub repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah great, thanks!

@sehilyi
Copy link
Member
sehilyi commented Apr 28, 2025 •
edited
Loading

@manzt, if you are okay with the change (mainly, the docs mentioned above), I will merge this and bump the gos version based on the README.md/Release instruction.

@manzt
Copy link
Member
manzt commented Apr 28, 2025

Great!

@sehilyi
Copy link
Member
sehilyi commented Apr 28, 2025

@manzt Which version should we release? Should we release the first major version, v1.0.0, so that the major version between Gos and Gosling.js is the same?

@sehilyi sehilyi merged commit 2c65821 into main Apr 28, 2025
4 checks passed
@sehilyi sehilyi deleted the create-pull-request/patch branch April 28, 2025 15:40
@manzt
Copy link
Member
manzt commented Apr 28, 2025 •
edited
Loading

@manzt Which version should we release? Should we release the first major version, v1.0.0, so that the major version between Gos and Gosling.js is the same?

For now, I would just make a minor release but it's up to you. I see the value in trying to align the two, but I anticipate we will benefit from versioning independently. In the release notes I would add some prose about what exactly changed. E.g.:

<auto generated notes>

## Notes

This release includes minor breaking changes that should not affect most users. 
(No updates were needed for any existing Gos examples.) The DataTrack has been
 removed, and several internal properties have been renamed with a leading _ to 
mark them as private. If you were relying on any of these, please open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manzt manzt manzt left review comments

@sehilyi sehilyi sehilyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sehilyi @manzt
0