8000 Support single channel ogg/vorbis by omccully · Pull Request #10 · gopxl/beep · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support single channel ogg/vorbis #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

omccully
Copy link
Contributor

Before, single channel ogg/vorbis audio played at 2x speed because it was reading in 2 samples each time.

@duysqubix duysqubix requested a review from a team October 10, 2023 00:46
@duysqubix
Copy link
Contributor

lgtm, I'll wait on @MarkKremer for final say.

@MarkKremer
Copy link
Contributor

Looks good! I'll test this before the end of tomorrow (CEST).

@MarkKremer MarkKremer merged commit c9fe196 into gopxl:master Oct 11, 2023
@MarkKremer MarkKremer changed the title add support for single channel ogg/vorbis Support single channel ogg/vorbis Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0