8000 goravel-socket by hulutech-web · Pull Request #61 · goravel/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

goravel-socket #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 30, 2024
Merged

goravel-socket #61

merged 7 commits into from
May 30, 2024

Conversation

hulutech-web
Copy link
Contributor

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

hwbrzzl
hwbrzzl reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to copy your README here, only need to update the table:

https://github.com/goravel/docs/blob/master/prologue/packages.md

image

@hulutech-web
Copy link
Contributor Author

goravel socket package

@hulutech-web
Copy link
Contributor Author

update packages.md

kkumar-gcc
kkumar-gcc 8000 reviewed May 29, 2024
View reviewed changes
prologue/packages.md Outdated
@@ -11,4 +11,5 @@ You can find extended packages for Goravel here, and you can also create a PR fo
| [goravel/s3](https://github.com/goravel/s3) | A S3 disk driver for `facades.Storage()` | 77.8% |
| [goravel/oss](https://github.com/goravel/oss) | A OSS disk driver for `facades.Storage()` | 76.5% |
| [goravel/redis](https://github.com/goravel/redis) | A Redis disk driver for `facades.Cache()` | 79.1% |
| [goravel/cloudinary](https://github.com/goravel/cloudinary) | A Cloudinary disk driver for `facades.Cache() | 75.4% |
| [goravel/cloudinary](https://github.com/goravel/cloudinary) | A Cloudinary disk driver for `facades.Cache() | 75.4% |
| [goravel/socket](https://github.com/hulutech-web/goravel-socket)| A webSocket package | 68.4% | 68.4%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [goravel/socket](https://github.com/hulutech-web/goravel-socket)| A webSocket package | 68.4% | 68.4%
| [hulutech-web/goravel-socket](https://github.com/hulutech-web/goravel-socket)| A webSocket package | 68.4% | 68.4%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already change name in prologue/packages.md

@hulutech-web
Copy link
Contributor Author

already change name in prologue/packages.md

@kkumar-gcc
Copy link
Member
kkumar-gcc commented May 29, 2024 •
edited
Loading

Please remove websocket/readme.md and zh/websocket/readme.md since these can be added to your package repository.`

@hulutech-web
Copy link
Contributor Author

already remove should be not necessary files websocket/readme.md and zh/websocket/readme.md

hwbrzzl
hwbrzzl reviewed May 29, 2024
View reviewed changes
prologue/packages.md Outdated
@@ -11,4 +11,5 @@ You can find extended packages for Goravel here, and you can also create a PR fo
| [goravel/s3](https://github.com/goravel/s3) | A S3 disk driver for `facades.Storage()` | 77.8% |
| [goravel/oss](https://github.com/goravel/oss) | A OSS disk driver for `facades.Storage()` | 76.5% |
| [goravel/redis](https://github.com/goravel/redis) | A Redis disk driver for `facades.Cache()` | 79.1% |
| [goravel/cloudinary](https://github.com/goravel/cloudinary) | A Cloudinary disk driver for `facades.Cache() | 75.4% |
| [goravel/cloudinary](https://github.com/goravel/cloudinary) | A Cloudinary disk driver for `facades.Cache() | 75.4% |
| [hulutech-web/goravel-socket](https://github.com/hulutech-web/goravel-socket)| A webSocket package | 68.4% | 68.4%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update zh/prologue/packages.md, and I don't find any test file in the package, maybe set Test Coverage to 0%?

Suggested change
| [hulutech-web/goravel-socket](https://github.com/hulutech-web/goravel-socket)| A webSocket package | 68.4% | 68.4%
| [hulutech-web/goravel-socket](https://github.com/hulutech-web/goravel-socket)| A webSocket package | 68.4% |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok，course i am not Skillfully use test suit，i can also add it a few days

@hulutech-web
Copy link
Contributor Author

already update zh/prologue and modify test coverage

hwbrzzl
hwbrzzl previously approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor
@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hwbrzzl hwbrzzl merged commit 3322e60 into goravel:master May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkumar-gcc kkumar-gcc kkumar-gcc left review comments

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hulutech-web @kkumar-gcc @hwbrzzl
0