8000 feat: [#338] Support c.Request().BindQuery to bind query params to a struct by kkumar-gcc · Pull Request #562 · goravel/framework · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: [#338] Support c.Request().BindQuery to bind query params to a struct #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2024
Merged

feat: [#338] Support c.Request().BindQuery to bind query params to a struct #562

merged 4 commits into from
Jul 13, 2024

Conversation

kkumar-gcc
Copy link
Member

📑 Description

Closes goravel/goravel#338

@coderabbitai summary

✅ Checks

  • Added test cases for my code

@kkumar-gcc kkumar-gcc requested a review from a team as a code owner July 13, 2024 05:43
@coderabbitai coderabbitai
8000 Copy link
Contributor
coderabbitai bot commented Jul 13, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • 🚀 Review Ready

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kkumar-gcc kkumar-gcc closed this Jul 13, 2024
@kkumar-gcc kkumar-gcc reopened this Jul 13, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.32%. Comparing base (5050f92) to head (6a5e903).

Additional details and impacted files 
@@            Coverage Diff      
8000
       @@
##           master     #562      +/-   ##
==========================================
- Coverage   70.34%   70.32%   -0.02%     
==========================================
  Files         180      180              
  Lines       11212    11212              
==========================================
- Hits         7887     7885       -2     
- Misses       2751     2752       +1     
- Partials      574      575       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devhaozi
devhaozi reviewed Jul 13, 2024
View reviewed changes
devhaozi
devhaozi approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member
@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkumar-gcc kkumar-gcc enabled auto-merge (squash) July 13, 2024 06:05
@kkumar-gcc kkumar-gcc merged commit 902302b into master Jul 13, 2024
9 of 10 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#338 branch July 13, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhaozi devhaozi devhaozi approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Support c.Request().BindQuery to bind query params to a struct
2 participants
@kkumar-gcc @devhaozi
0