8000 feat: [#578] Add bool type for migration by almas-x · Pull Request #826 · goravel/framework · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: [#578] Add bool type for migration #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: [#578] Add bool type for migration #826

merged 1 commit into from
Jan 22, 2025

Conversation

almas-x
Copy link
Contributor
@almas-x almas-x commented Jan 22, 2025 •
edited
Loading

📑 Description

Add bool type for migration,like

table.Boolean("is_name").Default(true)

Closes goravel/goravel#578?

@coderabbitai summary

✅ Checks

  • Added test cases for my code

@almas-x almas-x requested a review from a team as a code owner January 22, 2025 09:35
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jan 22, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

hwbrzzl
hwbrzzl reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor
@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR 👍 I just worked on it 5 minutes just now, you can update the assignee first next time. 😆

@hwbrzzl
Copy link
Contributor
hwbrzzl commented Jan 22, 2025

CI failed, and the branch name can be: almas/#578

@almas-x
Copy link
Contributor Author
almas-x commented Jan 22, 2025

Great PR 👍 I just worked on it 5 minutes just now, you can update the assignee first next time. 😆

Okay 🤣

@almas-x almas-x closed this Jan 22, 2025
@almas-x almas-x deleted the almas#578 branch January 22, 2025 09:52
@almas-x almas-x restored the almas#578 branch January 22, 2025 09:53
@codecov Codecov
Copy link
codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.79%. Comparing base (245f598) to head (3ce5d46).
Report is 1 commits behind head on v1.15.x.

Additional details and impacted files 
@@             Coverage Diff             @@
##           v1.15.x     #826      +/-   ##
===========================================
+ Coverage    69.78%   69.79%   +0.01%     
===========================================
  Files          218      218              
  Lines        18876    18886      +10     
===========================================
+ Hits         13172    13182      +10     
  Misses        4988     4988              
  Partials       716      716

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almas-x almas-x reopened this Jan 22, 2025
hwbrzzl
hwbrzzl reviewed Jan 22, 2025
View reviewed changes
@almas-x almas-x merged commit dfc4083 into v1.15.x Jan 22, 2025
21 checks passed
@almas-x almas-x deleted the almas#578 branch January 22, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almas-x @hwbrzzl
0